I'm working on changing the default behaviour of t...
# contributing
m
I'm working on changing the default behaviour of the "relate to original" button. Setting it to "false" instead of "true" wasn't too hard but I want to make this a configuration in the appsettings. I've added this as a setting to the appsettings but unfortunately this"
var relateToOriginalSettingsValue = builder.Config.GetSection($"{Constants.Configuration.ConfigContent}").GetValue<bool?>(nameof(ContentSettings.RelateToOriginalDefault));
returns
null
. So maybe I forgot to add it somewhere or I'm just not testing it correctly. What appsettings.json file should I modify to test this new functionality in the UmbracoCMS project?
s
I would say: don't make it a config, configs complicate things too much! 😅 It will be a "breaking" change but I think one worthwhile making, as I am not sure people actually use this option a lot. I would move the toggle to the top as well, so that it's always the first thing in the view.
k
I will raise a hand for it being kept as is. From a multi-lingual site setup point of view the relate to original is quite important. if people create a clone of their main site, for use in another language and they don't have this box ticked. then the relationship between the languages is lost. if at a later date they then realise that actually they did need that relationship fixing it is a very time consuming job (you have to link each page). There are times when people have done this and then attempted to translate their site and then had to do a LOT of work to fix it. the majority of people copy - and because its default it happens for them, so they don't have any issues later down the line. it might not have the right name, because people think it's some form of clever content relationship when its not , but page linking is quite important for some people.
j
This is the problem with the relation UI. It's not clear enough to editors what relate is for or why it might be useful. IMO, the "relation" nomenclature shouldn't be present in this part of the UI since relations are a more abstract concept and this is talking about a specific relationship with a specific meaning.
m
Changing it without making it configurable wasn't too hard indeed. When is something considered a breaking change? Changing this to default to false would not break anything (I thought so at least).
I can certainly understand your point of view and agree that it's important in those cases. That's why I wanted to make it configurable so that depending on the customer you can change the behaviour.
I was also considering making the "including descendants" option configurable since it's in the same menu and there might be a desire to change its default behaviour as well.
I'd love to continue this discussion here: https://github.com/umbraco/Umbraco-CMS/discussions/13802 let me know your opinion about this.