How to extend Umbraco Webhooks V13
# newsw
Warren Buckley
11/01/2023, 4:35 PMHow to extend Umbraco Webhooks V13 feature to listen against different notifications
https://blog.hackmakedo.com/2023/11/01/adding-a-custom-webhook-type-to-umbraco-v13/
k
Kevin Jump
11/01/2023, 9:52 PMI'm right behind you 🙂
w
Warren Buckley
11/02/2023, 8:22 AMGreat minds think alike 😄
Warren Buckley
11/02/2023, 8:23 AM@Kevin Jump does this work without the base class problem I was running into?
Warren Buckley
11/02/2023, 8:51 AMAlso not sure just a me thing?! But is the first event you trigger in my case save and publish take longer to say it’s published.. ie in its processing/loading state whilst it waits for a response back.
k
Kevin Jump
11/02/2023, 8:57 AMim not using the base class here, because its limited to IEntity types (or as you have seen IContentBase types) and i am actually sending things that are neither of those 🙂
I think 'base' is a misname for it really, its BaseContentWebHook 😉
Kevin Jump
11/02/2023, 8:57 AMi do think the webhooks slow things down, i am going to experiment today with farming the request off to a background process (see if that makes it fire and forget) in the notification handler of the webhook
w
Warren Buckley
11/02/2023, 8:59 AMYou at hackathon today?
Warren Buckley
11/02/2023, 8:59 AMBe good to swap notes 🙂
k
Kevin Jump
11/02/2023, 8:59 AMno 😦 at home - can't make it this year
w
Warren Buckley
11/02/2023, 9:00 AMAh shame
Warren Buckley
11/02/2023, 9:00 AMWell remote collab it is then 🤪
Warren Buckley
11/02/2023, 9:00 AMDo you have an example for just a normal INotitication
Warren Buckley
11/02/2023, 9:00 AMI can update the blog post and mention you as a source 🙂
k
Kevin Jump
11/02/2023, 9:05 AMyeah - i am just tiding up what i did last night, and then i will have a public repo with it in. i'll pop over the link when its live.
w
Warren Buckley
11/02/2023, 9:06 AMOkey doke
Warren Buckley
11/02/2023, 9:06 AMWell seems like I won’t bother looking into this today then… 🤣
Warren Buckley
11/02/2023, 9:13 AMFrom my tiny phone screen reading code off GitHub just need to implement IWebHookEvent but I assume you already know this Kevin.
k
Kevin Jump
11/02/2023, 9:25 AMyes , although you end up making your own base class for it quite quickly 🙂 -
Kevin Jump
11/02/2023, 9:26 AMi think really there is probibly a proper base class missing in the core, so you don't have to do your own, "Is this server running the right role" check on everything
Kevin Jump
11/02/2023, 9:32 AMKevin Jump
11/02/2023, 9:33 AMif you just want a 'clean' example exportCompleted is probibly it. https://github.com/Jumoo/uSync.Webhooks/blob/master/uSync.Webhooks/Webhooks/uSyncExportCompletedWebhook.cs
Kevin Jump
11/02/2023, 9:56 AMohh - Putting the webhook firing calls into a background task makes Umbraco way quicker (so might fix your slow to save and publish problem)
w
Warren Buckley
11/02/2023, 10:37 AMAh ok nice I am gonna take a look
Warren Buckley
11/02/2023, 10:37 AMGonna do a clone and take a look then perhaps we can log more issues on CMS repo as like you say implementing your own base class to repeat a lot of common logic is probably not ideal workflow
Warren Buckley
11/02/2023, 11:34 AM@Kevin Jump 404's repo - https://github.com/Jumoo/uSync.Webhooks
Warren Buckley
11/02/2023, 11:35 AMPrivate and not public ?!
k
Kevin Jump
11/02/2023, 11:35 AMindeed - public now.
w
Warren Buckley
11/02/2023, 11:35 AMThx
k
Kevin Jump
11/02/2023, 11:35 AMdev/webhooks branch has a receving controller, so in theory i can webhook to another Umbraco 🙂
w
Warren Buckley
11/02/2023, 11:37 AMYeh your doing a lot of repetitive work that we should not have to do - but kudos appreciate the example mate 😄
Warren Buckley
11/02/2023, 11:38 AMWill update blog later on to your example
k
Kevin Jump
11/02/2023, 11:39 AMyeah, i think a proper base class, and maybe an attribute (so a lot like migrations or healthchecks). would make it a lot cleaner.
w
Warren Buckley
11/02/2023, 11:42 AMYeh not sure I have enough time here today to help do a PR for that 😛
Warren Buckley
11/02/2023, 11:42 AMLike your implementation for the receving WebHook 💪
k
Kevin Jump
11/02/2023, 11:42 AMyeah - i am not sure if i do either, got to do some 'proper' work this afternoon 😦
w
Warren Buckley
11/02/2023, 11:48 AMhahah what I thought this is your proper work 😛
Warren Buckley
11/02/2023, 11:48 AMUpdated blog post with a link back to your repo at the bottom of the post
https://blog.hackmakedo.com/2023/11/01/adding-a-custom-webhook-type-to-umbraco-v13/
k
Kevin Jump
12/11/2023, 4:06 PMHi warren, do you have your custom example still working for rc4 - I am probibly doing something stupid, but when i go to append. so now :
Copy code
cs
builder.WebhookEvents()
.Append<uSyncItemImportedWebhookEvent>();Kevin Jump
12/11/2023, 4:06 PMcauses and error at boot 😦
Kevin Jump
12/11/2023, 4:07 PM Copy code
System.TypeLoadException: 'GenericArguments[0], 'Umbraco.Cms.Core.Webhooks.WebhookEventCollectionBuilder', on 'Umbraco.Cms.Core.Composing.OrderedCollectionBuilderBase`3[TBuilder,TCollection,TItem]' violates the constraint of type parameter 'TBuilder'.'Kevin Jump
12/11/2023, 4:07 PM(this is a fresh project, started the notifications again with attributes, and base classes)
Kevin Jump
12/11/2023, 4:08 PMI'll pop it in one of the issues if you don't think its obvious !
Kevin Jump
12/11/2023, 4:14 PMindeed - stupid, referenced where wrong in the sub project. 🤦♂️
w
Warren Buckley
12/11/2023, 8:25 PMOh well. Least it was an easy fix 🙂
17 Views