Can anyone give any quick insight into
w
Can anyone give any quick insight into whats new/changed in preview 007 I can't keep up at the mo
w
OK thats the C# side, any changes noted from the JS/UI side ?
k
in typescript the
UMB_PARTIAL_VIEW_PICKER_MODAL
has gone somewhere, don't know where.
but most everything else i have still "builds"
ofcourse that doesn't mean it hasn't all changed
Yeah - so first pass. my custom section doesn't load anymore 😦
s
Yeah, I don't see anything related to TimeDashboard in the backoffice any more
k
yeah, its not loading the entry point
so no custom code from that repo is loading 😦
s
There's also been a rename:
Copy code
src/tree/types.ts:1:10 - error TS2724: '"@umbraco-cms/backoffice/tree"' has no exported member named 'UmbEntityTreeItemModel'. Did you mean 'UmbUniqueTreeItemModel'?

1 import { UmbEntityTreeItemModel, UmbEntityTreeRootModel } from "@umbraco-cms/backoffice/tree";
           ~~~~~~~~~~~~~~~~~~~~~~

src/tree/types.ts:1:34 - error TS2724: '"@umbraco-cms/backoffice/tree"' has no exported member named 'UmbEntityTreeRootModel'. Did you mean 'UmbUniqueTreeRootModel'?

1 import { UmbEntityTreeItemModel, UmbEntityTreeRootModel } from "@umbraco-cms/backoffice/tree";
w
And seems you need to talk to Niels according to your console.log
Well maybe try the suggestions from the typescript compiler Seb. Seems to be making a good guess I reckon
s
Yeah they don't help with the entrypoint, but they fix the build indeed
w
Does it even load the entrypoint file? Shove a good ole console.log in there to see if it even loads/gets invoked
k
done that
didn't log 😦
w
If so then perhaps the schema/property changed
Hmm interesting….
Has C# side changed the package manifest thingy?
And assume the file not in the network request. If the file not loaded in then it’s time to compare against CMS core codebase and a game of spot the difference of an entrypoint file
s
It's my bedtime,
"@umbraco-cms/backoffice": "^14.0.0--preview008",
is available by the way @Kevin Jump but that didn't fix anything either
w
Wow moving at break neck speed. I only noticed 007
s
only for npm, not for dotnet
w
So the two are not necessarily in sync. Should they be?
s
no idea
k
as far as i know, the loading of the packages is all done on the front end.
but i don't know how
w
Yeh I may be totally wrong and just used to the old way of the server scanning the folders for package.manifest obviously now umbraco-package.json or whatever it is. But yeh may be 100% pure js that does that crawling to find them
k
they might be scanned in the c#
w
But yeh time to stop chatting code at this time of day and watch something on telly. Tomorrow’s problem to investigate. If anyone gets anywhere in the mean time be curious to know what it is.
Nighty night 💤
k
night ,
j
hmm, yeah we changed a bit on where we scan for umbraco-package.json so it doesn't dive into deep node_modules folders if you leave those in your App_Plugins folder. Maybe it broke RCLs. Can you verify if an umbraco-package.json can load from a local App_Plugins directory?
also @Sebastiaan if you see preview008 that means you are looking directly at npmjs.org where we put out "next" versions on another tag. You should pull the package down from the myget registry. We should probably remove the npmjs.org release.
s
I seem to have gotten it from myget? I think.. lol
k
hi @Jacob Overgaard looking it does find my umbraco-package.json, but because i don't have an "importMap" section i don't think it gets any further ?
j
there's a snippet in our tutorials on the docs:
Copy code
npm install --legacy-peer-deps --registry https://www.myget.org/F/umbracoprereleases/npm/ -D @umbraco-cms/backoffice@14.0.0--preview007
s
fair enough, I just bumped the packages.json, so I guess the problem really is: how will someone pulling down the repo know that they get the correct version?
j
the registry is stored in the package-lock.json file so that happens automatically
s
cool!
j
you can install simultaneously from npmjs.org and myget.org, but if you for some reason happens to set the main registry to myget, we are proxying all dependent packages from npmjs.org anyway through a setting in myget
Must be something up with the json converter
k
ahh the joys of System.Text.Json our new friendly json serializer 🙂
j
haha
it works on the v14/dev branch though
I think something went wrong in the release, something was patched just as we did the release
r
Also broken in RCL setup, with the same console message to talk to Niels. I've also tried manually copying the folder to App_Plugins but I still can't seem to get it to load
k
yeah i think don't upgrade is the message for the day 🙂
j
@rickbutterfield @Kevin Jump thank you so much for testing. If I may ask you one last thing, if you look in the network tab for the request to
/manifest
, could you tell me if it looks similar distorted to the screenshot, I shared above?
s
Yeah I have that on preview 7
Copy code
json
[
    {
        "name": "@umbraco-cms/backoffice",
        "version": "14.0.0--preview008",
        "extensions": []
    },
    {
        "name": "My.Vanilla.Extension",
        "version": "0.1.0",
        "extensions": [
            {
                "type": [],
                "alias": [],
                "name": [],
                "js": [],
                "weight": [],
                "meta": [
                    [
                        []
                    ],
                    [
                        []
                    ]
                ],
                "conditions": [
                    [
                        [
                            []
                        ],
                        [
                            []
                        ]
                    ]
                ]
            }
        ]
    }
]
j
So from what I understand, this is caused by the contextual serializer, which apparently was not in a working order when we did the release. Sometimes it would let Newtonsoft take over, other times System.Text.Json. From what I hear, this has been fixed on the latest dev branch. I'm ramping up to do a manual nightly release. If that works, I should be able to overwrite the preview007 release on myget with this patch.
r
Same kind of thing here...
Copy code
[
    {
        "name": "@umbraco-cms/backoffice",
        "version": "14.0.0--preview007",
        "extensions": []
    },
    {
        "name": "Umbraco.Community.Sustainability",
        "version": "1.0.0-alpha.2",
        "extensions": [
            {
                "name": [],
                "alias": [],
                "type": [],
                "js": []
            }
        ]
    }
]
k
i think you should increment the preview number though, otherwise everyone is going to also have to delete their nuget caches, if you already have it it doesn't fetch it again. 🙂
s
I'd prefer a preview008 as well
k
hey we have space for 1000 😉
j
haha true
yeah, we are just waiting for some fixes to the document type editor, then we should probably do a preview008 directly
if you have the nightly feed loaded up, this version should have been the intended preview007: 14.0.0--preview008.preview.367.gda41373
3 Views