https://discord.umbraco.com logo
Join Discord
Powered by
If you were there in UmbraCollab, just
# social
s
I played with the 
csproj
a bit more, and it's no longer including that 
Client
folder now - I don't know for sure if that did the trick but when I installed it in a new, clean 14RC1.. it works!! Marker and all (and it saves, etc.).
w
Woohoo. Look forward to playing catch-up and watching this over weekend 🙂
s
@Warren Buckley happy to see we think alike here, you are doing the exact same thing! https://github.com/warrenbuckley/Examine-Peek/blob/main/ExaminePeek/ExaminePeek.csproj#L40C1-L41C33 And I now see, I need to add that 
<None Include
as well otherwise I can't see some files in my IDE in the 
Client
folder. https://cdn.discordapp.com/attachments/1230501800940015717/1230787828049383444/image.png?ex=6634977d&is=6622227d&hm=ca75bde9313eb00bc049cba9d4055dcc3742a687d27e5f82d678c61a137c1213&
Congrats on v1.0.0 by the way 🎉
Copy code
xml
    <ItemGroup>
        <Content Remove="Client\**" />
        <Content Include="Client\assets\*.json" Pack="false" />
        <Content Include="Client\assets\public\umbraco-package.json" Pack="false" />
    </ItemGroup>
Had to change it to this as I wanted to see those files in my IDE: https://cdn.discordapp.com/attachments/1230501800940015717/1230788249379930154/image.png?ex=663497e1&is=662222e1&hm=86491776683af477abe9a3f852510b5f7fe957308fca2b7ebe681e5731b996ff&
w
Ah yeh have to do a bit of Csproj gymnastics and I still need to blog about the xml docs that help improve Swagger
s
But all good, it doesn't put them in the nuget output now with the 
Pack="false"
- exactly what I needed 🙌
w
I wasn’t too bothered of seeing them in wwwroot as they are the build output and files I won’t edit/touch
But yeh glad you found the same approach useful matey
s
No these are the files in the 
Client
folder, you see the package.json disappeards and tsconfig.json, so this makes them available again in VS/Rider
Copy code
xml
        <Content Include="Client\assets\*.json" Pack="false" />
        <Content Include="Client\assets\public\umbraco-package.json" Pack="false" />
Guess you're using VS Code?
w
Yeh VSCode mostly for client stuff and then just using a build script to pack
Only user Rider for the c# bits
s
Got it! What is the 
ExaminePeek.targets
file for though? Just the 
ExaminePeek.dll.xml
file to be included?
Doesn't look like you need it, sent you a PR: https://github.com/warrenbuckley/Examine-Peek/pull/3\
w
Oooh thanks will check when back at computer next week.
PreviousNext
Powered by