https://discord.umbraco.com logo
Join Discord
Powered by
BES test række hovedevent retest
# contributing
k
Before I start diving too deep into this, I'm SO curious if anyone has any ideas or pointers. I'm aware of https://github.com/umbraco/Umbraco-CMS/pull/16572, and am currently testing on 13.4.0-rc2 where that has been merged in. We are seeing our dictionary values being picked with the wrong language, on VirtualPageController views - but - only in some browsers. Try this page (at least in Windows) on Edge and then in Chrome https://ffbdev.finansforbundet.dk/dk/arrangementer/bes-test-raekke--hovedevent-retest/22001107/ Umbraco picks Danish for Chrome for the "Log ind og tilmeld" button and the breadcrumbs but it picks English "Login and signup" in Edge - I don't have the imagination as to how we end up with different languages on something that should be a server decision ?
s
Doesn't seem so strange.. some of them asked for Danish, others did not and you had an English version defined. Please add to the issue what your `<html lang="..." `value is as well. Mind you, I only skimmed the issue, so I might have missed something, but it seems like expected behavior.
j
If I open the link in first edge then chrome then I also get 2 different results, even though I've never visited the site before. Pretty strange tbh
s
But what do each of those two browsers have configured as the languages you want?
Somehow though.. even after removing English from the Edge setting (or Chrome), it sends the correct headers but gives me an English button always. Never seen the Danish version. Is your culture & hostnames set up for 
da
or 
da-DK
? I can see it send the header asking for 
da
(or 
nl
but that's not relevent here). https://cdn.discordapp.com/attachments/1252922234541178900/1252974941503229952/image.png?ex=66742b59&is=6672d9d9&hm=ab5a4756fddfbbabb9296133fae1800ec54d27cf94ed51dd395d9994b35db6ac&
k
It's a way deeper issue and is an regression from 13.3.0 due to the new eagermatcherpolicyhttps://github.com/umbraco/Umbraco-CMS/issues/16626
I could set the html lang, set a domain explicitly Set the domain to Danish and it will still return an English dictionary item if the http request doesn't start with da-DK in the accept-lang header
Look at my poc it shows a reproducible solution
That doesn't require a specific browser
And the browser doesn't get to chose the language, this site had a /dk and a /en for that, I've rolled our production back to 13.3.0 to get it working again, if someone are on a defined Danish page, it should never show an English dictionary item. I've kept one of the test environments on 13.3.2 for this chat while I made my poc example
s
Just to update, indeed I missed something! 😅 Sorry for only managing to skim-read that! Team is looking at it.. hopefully possibly trying to fix it for 13.4.0 🤞
k
@Sebastiaan thanks! 🙂 Thought of an even worse way this affects sites. So my site at least fell back to English because we do danish/english If you have a site that does say danish/swedish or Spanish/Portugeese or something, you end up with blank dictionary values in all items
@Sebastiaan credit where credit is due - that's a really impressive turnaround - huge thanks to everyone who helped get this in already in 13.4.0
s
Great to hear it was fixed so quickly!
PreviousNext
Powered by