https://discord.umbraco.com
Join Discord
Suggestion: Allow setting icon for marketplace listing with JSON
# package-development
w
*Suggestion for marketplace @Ronald Barendse & @nathanwoulfe * Can we set the icon for the marketplace listing via umbraco-marketplace.json (as I just forgot it on the nuget package 🙈 )
s
with the added benifit that it then also shows up on NuGet 😍
w
Yes I know matey. But when you are idiot like me and have forgotten to set it before you published it to Nuget. As you can't amend the meta or replace the nuget package just to update an icon. Oh well maybe there is 1.0.1 and I'll remember to do it then 😂
s
Yeah just upload a new version!
And a v1.0.1 with the only change being "added a logo" is perfectly fine.
You should steal my release workflow as well, it's so nice to be able to just push and let it all happen automatically: https://github.com/nul800sebastiaan/Cultiv.EnvironmentInspect/blob/bc096f6f33bed45c11bf7a939dbfd3da7cb7154c/.github/workflows/release.yml
To get the release workflow to run, you add a git tag to the appropriate commit: 
v1.0.1
would be your next tag to get it to release that version.
w
Yeh need to add the github automation stuff to these packages - but with my work I would have pushed out a ton of rubbish releases
Caught some issues by testing manually and building
Where if I can just add a tag and its on Nuget. I'll do that and forget to test and kaboom 😂 The manual upload of a nupkg keeps it semi safe for my chaotic mind/workflow
s
You only push a release when you add a tag in git - so 0 risk. You can still do all the local testing etc. When you're satisfied, add a git tag and off it goes.
I also have a pre-release version, to make absolutely sure it works first: https://github.com/nul800sebastiaan/Cultiv.EnvironmentInspect/blob/bc096f6f33bed45c11bf7a939dbfd3da7cb7154c/.github/workflows/release-preview.yml Then the tag is in 
v1.0.1-beta1
format.
w
OK will look tomorrow - brain currently fried trying to get my head around vite :S
3 Views
PreviousNext
Powered by

Umbraco

A hub and casual space for you to interact with fellow community members and learn more about Umbraco!

Powered by