Umbraco-CMS/src/Umbraco.Web.UI.Client/ex...
# package-development
n
Oh, I never spotted that this Example has a potential issue* Using a click event is not a solid approach as there could be other ways the user would be able to navigate. Especially when talking about navigation that uses URLs. *If the implementation is purely yours, the tabs are not using URLs and there is not other ways to navigate than using the tabs then you can do this, but otherwise I would recommend observing the responsibile for displaying the view(Ex. Router-Slot), instead of the navigation(Tabs, Tab-group)
r
And this the point I am feeling dumb again 😂 I read what you are saying but don't really understand it. Anyway click works for me it is just changing the state in a workspace view.
n
Oh, Richard, sorry that was never my intention. 😬 Let me re-formulate; if you are able to listen for the Click event, it must mean that you implement the tab-group. And then if you dont use the Router-Slot(not able to URL-wise navigate to tabs), then this is a fine approach. 👍 My thoughts where mainly on implementations using Tab that has URLs. I also just noticed, the example is alright, it does not have URLs for the Tabs.
r
No worries, Niels it's just a bit hard sometimes to understand all the new stuff for an almost 50 year old back-ender 😉
7 Views