https://discord.umbraco.com logo
#social
Title
# social
j

Jason

06/29/2022, 8:16 AM
I have an idea for an UmbraCollab at some point. Work out exactly what it is about my face in particular that our.umbraco.com finds so objectionable as to never show it in the contributions section.
c

Corné Hoskam

06/29/2022, 8:17 AM
I actually know the answer to that! And not just because my face is in the same situation 😂
The Contributions API from github only returns the top... 100?, and I think the Our.Umbraco code even only paginates the first page of that. So unless you decide to massively contribute within a specific timespan, the API won't return you sadly
r

ravimotha

06/29/2022, 8:20 AM
so unless you qualify recently and you contribute heavily enough you may not necessarily see your lovely avatar.. and the pagination "helps" that further by just show the top x of that 100
j

Jason

06/29/2022, 8:23 AM
Ah, interesting. So that's top 100 of all time, even if recent contributions are lower? Would make sense as to why contributors still show up with a "1".
(because all-time it isn't 1)
c

Corné Hoskam

06/29/2022, 8:23 AM
Fairly certain that's why, yes!
j

Jason

06/29/2022, 8:30 AM
Interesting, I wonder if it would be straightforward to swap it out for the commits API.
Get all commits for last 12 months, using list of unique contributors from that then fetch the contribution stats for each one.
n

nathanwoulfe

06/29/2022, 9:20 AM
Commits could be gamed couldn't it? I could push one PR with 50 commits...
j

Jason

06/29/2022, 9:42 AM
True, but that's how github measures it anyway.
n

nathanwoulfe

06/29/2022, 9:49 AM
To be fair, if you're taking any satisfaction from gaming a leaderboard for CMS contributions, you probably need to find a better hobby.
2 Views