https://discord.umbraco.com logo
#package-development
Title
# package-development
w

warrenbuckley

11/23/2022, 1:55 PM
Heads up new marketplace 'beta' is live https://marketplace.umbraco.com
If you have already tagged your package and added an
umbraco-marketplace.json
file you may need to redo it as the JSON has changed slightly. Good news is that there is a JSON schmea file to help with docs & autocompletions in say VSCode or other editors. Listing Docs/Info https://marketplace.umbraco.com/listing JSON Schema https://marketplace.umbraco.com/umbraco-marketplace-schema.json Updated Example for TagHelpers package [Using JSON Schema] https://github.com/umbraco-community/Our-Umbraco-TagHelpers/blob/main/umbraco-marketplace.json
/cc @leekelleher @codesharepaul @kevinjump @mattbrailsford & others.... (too many to tag everyone)
s

Sebastiaan

11/23/2022, 2:16 PM
@Matthew First discovery when the
umbraco-marketplace
tag gets added on nuget takes about a day, then it's every 2 hours we recheck for new info I believe.
m

Matthew

11/23/2022, 2:19 PM
I mean, when I click one of these it takes 2-4 seconds
I just gave a quick test where I opened 5 windows and tried to view a package on each at the same time. This increased the response considerably to almost 10 seconds!
Might be worth taking a look at before launch
w

warrenbuckley

11/23/2022, 2:25 PM
@Matthew log the issue here with repro steps please or even better with a video or gif https://github.com/umbraco/Umbraco.Marketplace.Issues/issues/new
m

Matthew

11/23/2022, 2:25 PM
Alrighty, will do
w

warrenbuckley

11/23/2022, 2:25 PM
Thanks save us relying the info and logging an issue on your behalf šŸ˜„
s

Sebastiaan

11/23/2022, 2:26 PM
I've pinged the team, but indeed, can reproduce that it's quite slow. No need for an issue right now!
m

Matthew

11/23/2022, 2:27 PM
Okay, issue logging cancelled!
s

Sebastiaan

11/23/2022, 2:28 PM
Ah maybe it's just cache, now it's fast again, maybe first load of each is slow? Anyway, I've asked them, let's see what they say!
m

Matthew

11/23/2022, 2:30 PM
Hmm, I was having it be slow regardless of which one I clicked (opening the same one was still slow), but now it is indeed fast
Perhaps more hamsters are running round now to speed up the servers?
m

Matthew

11/23/2022, 2:43 PM
Haha, must be
k

kevinjump

11/23/2022, 4:47 PM
feels a lot like feeding a black hole at the moment - update or new packages, haven't appeared, any idea what the polling time is ? and how we might know if it hasn't worked ?
s

Sebastiaan

11/23/2022, 4:59 PM
New packages about a day (4AM it runs I think). The json and budget updates used to run every 6 hours but that should be 2 hours now. If it doesn't work then let me know and I'll get someone to check
n

nikcio

11/23/2022, 8:26 PM
@Sebastiaan I'm having some problems getting the JSON data working on my package. Where should I look for help troubleshooting? https://github.com/umbraco/Umbraco.Marketplace.Issues/issues/new ?
s

Sebastiaan

11/23/2022, 8:27 PM
Yeah go for it!
m

Mark Drake (Next Player Up)

11/24/2022, 7:25 PM
Is there a GitHub repo for the marketplace where issues or discussions can be opened? šŸ™‚
s

Sebastiaan

11/24/2022, 9:41 PM
Literally 2 messages before this šŸ˜‰
m

Mark Drake (Next Player Up)

11/24/2022, 11:45 PM
Sorry, Iā€™m going to blame Thanksgiving on completely missing that. Wow! XD
s

Sebastiaan

11/25/2022, 8:32 AM
Turkey brain is a real problem! šŸ˜‚
k

kevinjump

11/25/2022, 11:37 AM
No its still throwing into the black hole šŸ˜ž - No doubt i've done something stupid - but I for example can't see why this one works. https://marketplace.umbraco.com/package/jumoo.translationmanager.languagewire but this one doesn't https://marketplace.umbraco.com/package/jumoo.translationmanager.lionbridge there json files are all but identical, in all but the same place, and one has been read the other hasn't both JSON files validate against the schema, both can be found on the project url +
umbraco-marketplace.json
(and
umbraco-marketplace-{packageid}.json
- I event have a powershell script to check this now that gets info from nuget, then goes to fetch the json and validates it - there needs to be somewhere you can say to the marketplace, does this look right, and it just goes through its location and parse process and says yes. -- because 2+ hours of maybe or maybe not fixing it isn't a fun developer experience.
l

leekelleher

11/25/2022, 12:08 PM
Which one is working LanguageWire or Lionbridge?
k

kevinjump

11/25/2022, 12:10 PM
Well languagewire is 'working, in that it has a company description, (but looking at it - it doesn't like the avatar url eaither so not 'working' working.
l

leekelleher

11/25/2022, 12:11 PM
As on the LanguageWire NuGet pkg https://www.nuget.org/packages/Jumoo.TranslationManager.LanguageWire the Project website link points to https://jumoo.co.uk/translate/languagewire/ but when you click on it, you get redirected to https://jumoo.co.uk/translate/providers/ ... so I'm thinking that could be an issue? but I CAN view the JSON file directly? https://jumoo.co.uk/translate/languagewire/umbraco-marketplace.json šŸ¤”
k

kevinjump

11/25/2022, 12:11 PM
yeah the pages (all of the providers) do redirect down, but the marketplace files are there.
l

leekelleher

11/25/2022, 12:12 PM
side note, I've been using this to validate against the JSON Schema... https://www.jsonschemavalidator.net/
k

kevinjump

11/25/2022, 12:12 PM
Yeah me to.
l

leekelleher

11/25/2022, 12:12 PM
k

kevinjump

11/25/2022, 12:14 PM
Yeah that one is brokem but there are more (also broken where they do redirect - e.g deepl (https://jumoo.co.uk/translate/deepl/umbraco-marketplace.json)
l

leekelleher

11/25/2022, 12:16 PM
Hmmm, not sure - JSON all looks fine to me šŸ¤”
k

kevinjump

11/25/2022, 12:17 PM
I can tell you because i do actually have secret access they check for the package id versions first. e.g https://jumoo.co.uk/translate/deepl/umbraco-marketplace-jumoo.translationmanager.connector.deepl.json
I have them all just to be sure šŸ˜ž
s

Sebastiaan

11/25/2022, 12:36 PM
FYI @kevinjump I've pinged Andy and also passed along that we should have a json validator tool in the marketplace site, even if it only gives you a bool works/doesn't work that would already be better. But preferably of course pointing out where the error is.
l

leekelleher

11/25/2022, 12:37 PM
like my silly mistake, of missing a comma... and not noticing for 8 days! šŸ¤£
k

kevinjump

11/25/2022, 12:41 PM
yeah i did something simlar a while back, it certainly would be start, but there are three of four things, 1) what is the URL the marketplace is looking for for the json file 2) does it actually get the file correctly from that location? 3) is it a valid json file (can do that now with JsonValidator site) 4) does the marketplace think its valid (e.g are the images URLs ok/etc)
at the moment it could be any one of those things not working, but you can only check No 3.
s

Sebastiaan

11/25/2022, 12:45 PM
Oh I just had another idea, we could do with a way to "claim" a package.. something like the
rel="me"
stuff that you use to verify yourself on Mastodon. I think I wouldn't want to have a "public" way of doing checks like this, only the package owner should be able to do them, to prevent abuse / easy DOS attacks.
@kevinjump Just saw an update:
Fixed issue loading from project URL with and without a trailing slash (was affecting one of Kevin's packages)
šŸ™ˆ Thanks again for helping debug, this seems like too simple a fix but it seems to have done the trick! šŸ˜…
m

mattbrailsford

12/02/2022, 10:29 AM
What is the order that packages appear? Is it order of discovery?
s

Sebastiaan

12/02/2022, 11:23 AM
Not sure I understand the question? šŸ˜… The order where? If you mean the commerce section, the default filter is on "Popular" which is basically number of NuGet downloads I believe.