Osman Coşkun
03/22/2024, 6:00 PMMike Chambers
03/23/2024, 11:33 AMImageCropMode = imageCropMode ?? ImageCropMode.Pad, // Not sure why we default to Pad
Looks like HQ aren't sure why a function called getCropUrl() defaults to pad either 🙂Mike Chambers
03/23/2024, 11:41 AMurlHelperExtension
based off https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Web.Common/Extensions/UrlHelperExtensions.cs.. and set the imageCropMode
to ImageCropMode.Crop rather than null? And then use your extension namespace?Mike Chambers
03/23/2024, 11:51 AMbuilder.Services.AddSingleton<IImageUrlGenerator, ImageSharpImageUrlGenerator>();
with a modified one that passes again a modified ImageUrlGenerationOptions
where the default imageCropMode is specified in the Options?
maybe...
public ImageCropMode? ImageCropMode { get; set; } = Models.ImageCropMode.Crop;
Not sure if this is the way to go... 🙂 just 🤔
https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Core/Media/IImageUrlGenerator.cs
https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Core/Models/ImageUrlGenerationOptions.cs#L18Mike Chambers
03/23/2024, 11:56 AMImageSharpImageUrlGenerator
you could just add a check for options.ImageCropMode == null in the GetImageUrl Method?
https://github.com/umbraco/Umbraco-CMS/blob/contrib/src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs#L68Osman Coşkun
03/23/2024, 4:29 PM